Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add @linkgoron to collaborators #37817

Merged
merged 1 commit into from
Mar 19, 2021
Merged

doc: add @linkgoron to collaborators #37817

merged 1 commit into from
Mar 19, 2021

Conversation

Linkgoron
Copy link
Member

fixes: #37619

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 19, 2021
@Linkgoron
Copy link
Member Author

👍 to fast track!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36813/

MylesBorins
MylesBorins approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

Welcome to the team @Linkgoron

Goron_Link_Artwork

@Linkgoron Linkgoron added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 19, 2021
@Linkgoron
doc: add @Linkgoron to collaborators
eaf0f0f 
fixes: nodejs#37619

PR-URL: nodejs#37817
Fixes: nodejs#37619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Linkgoron Linkgoron force-pushed the doc-add-@linkgoron-to-collaborators branch from 3f61c7e to eaf0f0f Compare March 19, 2021 17:40
@Linkgoron Linkgoron merged commit eaf0f0f into nodejs:master Mar 19, 2021
@Linkgoron
Copy link
Member Author

Landed in eaf0f0f

@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 19, 2021
@Linkgoron Linkgoron deleted the doc-add-@linkgoron-to-collaborators branch March 19, 2021 18:44
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@Linkgoron @ruyadorno
doc: add @Linkgoron to collaborators
4700042 
fixes: #37619

PR-URL: #37817
Fixes: #37619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
ruyadorno added a commit that referenced this pull request Mar 30, 2021
@ruyadorno
2021-03-31, Version 15.13.0 (Current)
2a38168 
Notable changes:

* buffer:
  * implement btoa and atob (James M Snell) #37529
* deps:
  * upgrade npm to 7.7.6 (Ruy Adorno) #37968
* doc:
  * add legacy status to stability index (James M Snell) #37784
  * add @Linkgoron to collaborators (Nitzan Uziely) #37817
* http:
  * add http.ClientRequest.getRawHeaderNames() (simov) #37660
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
ruyadorno added a commit that referenced this pull request Mar 30, 2021
@ruyadorno
2021-03-31, Version 15.13.0 (Current)
045dc91 
PR-URL: #37977

Notable changes:

* buffer:
  * implement btoa and atob (James M Snell) #37529
* deps:
  * upgrade npm to 7.7.6 (Ruy Adorno) #37968
* doc:
  * add legacy status to stability index (James M Snell) #37784
  * add @Linkgoron to collaborators (Nitzan Uziely) #37817
* http:
  * add http.ClientRequest.getRawHeaderNames() (simov) #37660
ruyadorno added a commit that referenced this pull request Mar 31, 2021
@ruyadorno
2021-03-31, Version 15.13.0 (Current)
71a7722 
PR-URL: #37977

Notable changes:

* buffer:
  * implement btoa and atob (James M Snell) #37529
* deps:
  * upgrade npm to 7.7.6 (Ruy Adorno) #37968
* doc:
  * add legacy status to stability index (James M Snell) #37784
  * add @Linkgoron to collaborators (Nitzan Uziely) #37817
* http:
  * add http.ClientRequest.getRawHeaderNames() (simov) #37660
ruyadorno added a commit that referenced this pull request Mar 31, 2021
@ruyadorno
2021-03-31, Version 15.13.0 (Current)
82bc5c3 
PR-URL: #37977

Notable changes:

* buffer:
  * implement btoa and atob (James M Snell) #37529
* deps:
  * upgrade npm to 7.7.6 (Ruy Adorno) #37968
* doc:
  * add legacy status to stability index (James M Snell) #37784
  * add @Linkgoron to collaborators (Nitzan Uziely) #37817
* http:
  * add http.ClientRequest.getRawHeaderNames() (simov) #37660
targos pushed a commit that referenced this pull request May 1, 2021
@Linkgoron @targos
doc: add @Linkgoron to collaborators
b2d3ac8 
fixes: #37619

PR-URL: #37817
Fixes: #37619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating @Linkgoron as collaborator
4 participants
@Linkgoron @nodejs-github-bot @MylesBorins @Trott